Improve the performance of the FusionCacheProvider #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An `InvalidOperationException` is always better than a `NullReferenceException`, even in unit tests.
No matter how it's retrieved, either through IFusionCacheProvider or directly by requesting the IFusionCache.
By storing the caches in a dictionary so that retrieving the cache can be performed in O(1) instead of O(n).
|
Hi @0xced I updated this branch based on the new main, and pushed some changes which build upon your work and can make it even better. Basically instead of storing an IEnumerable to iterate on at every Finally I've made the tests a little better around these scenarios. Thoughts? |
jodydonetti
approved these changes
Jun 5, 2024
jodydonetti
changed the title
|
Looks good to me too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing the caches in a dictionary upfront allows to retrieve the cache in O(1) instead of O(n).
Using
Lazy<IFusionCache>allows to preserve the semantic of throwing when accessing the (incorrectly configured) caches.Also, the
DependencyInjectionTestswere very slightly improved:GetRequiredServiceinstead ofGetServiceplus the null-forgiving operator because anInvalidOperationExceptionis always better than aNullReferenceException, even in unit tests.IFusionCacheinstance is always the same no matter how it's retrieved, either throughIFusionCacheProvideror directly by requesting theIFusionCache.